From d1c47a328785ece9a8ffd9bbca3138818b8203b3 Mon Sep 17 00:00:00 2001 From: _ov4 Date: Sun, 26 Jul 2026 12:51:55 +0000 Subject: fix: close correctness gaps found by post-refactor adversarial review Confirmed by a 17-agent review pass over the refactor diff (12 findings verified against the code and reproduced end-to-end): - marshalCallArgs: BYREF arguments must match the declared parameter type exactly (was: silent bit-reinterpretation, e.g. REAL passed to BYREF INTEGER printed garbage with exit 0); whole-array arguments are rejected (was: callee assignment smashed the array data pointer -> runtime SIGSEGV) - Null guards for CHR/LCASE/UCASE/IS_NUM/NUM_TO_STR/STR_TO_NUM/ASC argument emission (was: compiler SIGSEGV on e.g. CHR(undeclared)), matching the guards MID/RIGHT/LEFT already had - ParseReturnStmt: propagate expression-parse failure (was: diagnostic printed but exit 0) and recognize bare RETURN before ENDWHILE/UNTIL/NEXT (was: bogus diagnostic on legal early return) - emitPrototype rejects FUNCTION/PROCEDURE names that collide with runtime/libc symbols (was: FUNCTION strlen silently hijacked the string runtime; arity mismatch crashed createArgumentAllocas) or with builtins (was: silently shadowed); conflicting redefinitions keep the first signature - FOR STEP is evaluated exactly once, before the loop (was: once per iteration; the runtime-direction refactor had moved it to N+1) - RETURN values are coerced to the declared return type via the signature table (RETURN n in a RETURNS REAL function now compiles) - '&' coerces its operands to STRING (CHAR/number operands work); OUTPUT of a PROCEDURE call reports a clean error AGENTS docs updated to match. All positive samples remain byte-identical to the pre-refactor baseline. Co-Authored-By: Claude Fable 5 --- lib/Parser/ParserFunction.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'lib/Parser') diff --git a/lib/Parser/ParserFunction.cc b/lib/Parser/ParserFunction.cc index 6ce0b8e..7663f38 100644 --- a/lib/Parser/ParserFunction.cc +++ b/lib/Parser/ParserFunction.cc @@ -137,8 +137,12 @@ std::unique_ptr Parser::ParseCallStmt() { std::unique_ptr Parser::ParseReturnStmt() { getNextToken(); std::unique_ptr Expr = nullptr; - if (CurTok != tok_endif && CurTok != tok_else && CurTok != tok_endfunction && CurTok != tok_endprocedure) { + // A bare RETURN is recognized right before any block terminator. + if (CurTok != tok_endif && CurTok != tok_else && CurTok != tok_endfunction && + CurTok != tok_endprocedure && CurTok != tok_endwhile && CurTok != tok_until && + CurTok != tok_next && CurTok != tok_eof) { Expr = ParseExpression(); + if (!Expr) return nullptr; } return std::make_unique(std::move(Expr)); } -- cgit v1.3.1-4-g156e