From 17993103e1ba1d142205eb2e41291edebc0e3a89 Mon Sep 17 00:00:00 2001 From: _ov4 Date: Thu, 22 Oct 2026 15:14:35 +0000 Subject: fix(parser): report missing THEN and ')' on the line that needs them Co-Authored-By: Claude Sonnet 5.5 --- lib/Parser/Parser.cc | 1 + lib/Parser/ParserControlFlow.cc | 13 ++++++++----- lib/Parser/ParserExpression.cc | 2 +- 3 files changed, 10 insertions(+), 6 deletions(-) (limited to 'lib/Parser') diff --git a/lib/Parser/Parser.cc b/lib/Parser/Parser.cc index d17856b..ad2e408 100644 --- a/lib/Parser/Parser.cc +++ b/lib/Parser/Parser.cc @@ -30,6 +30,7 @@ Parser::Parser(Lexer &L) : Lex(L) { void Parser::getNextToken() { int PreviousLine = CurTok == tok_eof ? 0 : Lex.getLine(); + PrevTokLine = PreviousLine; CurTok = Lex.gettok(); StartsLine = Lex.getLine() != PreviousLine; } diff --git a/lib/Parser/ParserControlFlow.cc b/lib/Parser/ParserControlFlow.cc index 7caf555..542ef0e 100644 --- a/lib/Parser/ParserControlFlow.cc +++ b/lib/Parser/ParserControlFlow.cc @@ -26,10 +26,13 @@ std::unique_ptr Parser::ParseIfStmt() { if (!Cond) return nullptr; if (CurTok != tok_then) { - cps::sourceError(Lex.getLine(), "expected THEN"); - return nullptr; + cps::sourceError(missingLine(), "expected THEN"); + // A THEN missing at the end of a line is reported and then treated as + // present so the rest of the statement still parses. + if (!StartsLine) return nullptr; + } else { + getNextToken(); } - getNextToken(); std::vector> ThenStmts = ParseBlock({tok_else, tok_endif}); @@ -93,7 +96,7 @@ std::unique_ptr Parser::ParseForStmt() { getNextToken(); if (CurTok != tok_assign) { - cps::sourceError(Lex.getLine(), "expected '<-' in FOR loop"); + cps::sourceError(missingLine(), "expected '<-' in FOR loop"); return nullptr; } getNextToken(); @@ -102,7 +105,7 @@ std::unique_ptr Parser::ParseForStmt() { if (!Start) return nullptr; if (CurTok != tok_to) { - cps::sourceError(Lex.getLine(), "expected TO in FOR loop"); + cps::sourceError(missingLine(), "expected TO in FOR loop"); return nullptr; } getNextToken(); diff --git a/lib/Parser/ParserExpression.cc b/lib/Parser/ParserExpression.cc index 8c5e8ce..b75f704 100644 --- a/lib/Parser/ParserExpression.cc +++ b/lib/Parser/ParserExpression.cc @@ -211,7 +211,7 @@ std::unique_ptr Parser::ParseParenExpr() { auto V = ParseExpression(); if (!V) return nullptr; if (CurTok != ')') { - cps::sourceError(Lex.getLine(), "expected ')'"); + cps::sourceError(missingLine(), "expected ')'"); return nullptr; } getNextToken(); -- cgit v1.3.1-4-g156e