aboutsummaryrefslogtreecommitdiff
path: root/lib/Parser
diff options
context:
space:
mode:
author_ov4 <ov4@ov4.org>2026-07-26 18:10:10 +0000
committer_ov4 <ov4@ov4.org>2026-07-26 18:10:10 +0000
commitc2c2e1771bf9b747f38dc145b5201b45c579d465 (patch)
tree09c752f360e56f523eb87e4a6dc17751be56210b /lib/Parser
parenta44f1246dbe24fc813a212a5ef3f5811b1d6402a (diff)
fix: close type-safety holes found by adversarial review; update docs
Review findings (all reproduced, then fixed and re-verified): - '^x' leaked as a raw address into any builtin context (s <- ^x printed the variable's bytes as a C string; NOT ^x, '&', and ^x = ^x compiled). Address-of is now rejected everywhere except a pointer-typed target. - A whole-array variable passed the nominal gate as a value of its ELEMENT type (s <- arrayOfSeason stored the raw data pointer; = on it emitted invalid IR). Whole arrays are now rejected as operands and as coercion sources; array parameters are unaffected. - Enum values smuggled into INTEGER through array subscripts and DECLARE bounds (a[Autumn], ARRAY[Spring:Winter]); both now go through emitCoercedExpr like every other INTEGER context. - An array DECLAREd inside an IF/WHILE/REPEAT/FOR body and used after the block was a wild-pointer write (constant bounds) or a verifier dump (runtime bounds). Arrays are now block-scoped: control-flow bodies snapshot and restore the ArrayTable, so escape is a clean compile error. - Duplicate parameter names silently shadowed (BYREF write-back defeated); now a parse error. Trailing comma in parameter lists accepted; now a parse error consistent with every other list. - A variable/array/parameter/function could reuse a TYPE name; reserved. - RETURN with a value inside a PROCEDURE was silently discarded (control did not return); now an error, as is a bare RETURN in a FUNCTION. - INPUT r.f mis-parsed into a three-error cascade; now one clear error. - Assigning to an enum constant now says so instead of 'Unknown variable'. Docs: ARCH/CONVENTIONS/EXTENDING/SUBSYSTEMS/PITFALLS rewritten for the TYPE system (ABI additions, nominal-typing invariants, admission-gate doors, array-parameter ABI, new recipes, new sharp edges); README features/TODO updated — random files are unblocked. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Diffstat (limited to 'lib/Parser')
-rw-r--r--lib/Parser/Parser.cc8
-rw-r--r--lib/Parser/ParserFunction.cc11
2 files changed, 19 insertions, 0 deletions
diff --git a/lib/Parser/Parser.cc b/lib/Parser/Parser.cc
index 9563650..260472c 100644
--- a/lib/Parser/Parser.cc
+++ b/lib/Parser/Parser.cc
@@ -542,7 +542,15 @@ std::unique_ptr<StmtAST> Parser::ParseStatementImpl() {
return nullptr;
}
std::string Name = Lex.IdentifierStr;
+ int Line = Lex.getLine();
getNextToken();
+ if (CurTok == '[' || CurTok == '.' || CurTok == '^') {
+ // Consume the whole designator so it cannot replay as statements.
+ std::vector<DesignatorAccess> Dummy;
+ ParseDesignatorSuffix(Dummy);
+ fprintf(stderr, "Error: INPUT target must be a plain variable at line %d\n", Line);
+ return nullptr;
+ }
return std::make_unique<InputStmtAST>(Name);
}
else if (CurTok == tok_output) {
diff --git a/lib/Parser/ParserFunction.cc b/lib/Parser/ParserFunction.cc
index 776a980..81db2c7 100644
--- a/lib/Parser/ParserFunction.cc
+++ b/lib/Parser/ParserFunction.cc
@@ -106,6 +106,13 @@ std::optional<std::vector<ParamDecl>> Parser::ParsePrototypeArgs(bool AllowByRef
return std::nullopt;
}
+ for (const ParamDecl &Prev : Params) {
+ if (Prev.Name == P.Name) {
+ fprintf(stderr, "Error: Duplicate parameter name '%s' at line %d\n",
+ P.Name.c_str(), Lex.getLine());
+ return std::nullopt;
+ }
+ }
Params.push_back(std::move(P));
if (CurTok == ')') break;
@@ -114,6 +121,10 @@ std::optional<std::vector<ParamDecl>> Parser::ParsePrototypeArgs(bool AllowByRef
return std::nullopt;
}
getNextToken();
+ if (CurTok == ')') {
+ fprintf(stderr, "Error: Expected another parameter after ',' at line %d\n", Lex.getLine());
+ return std::nullopt;
+ }
}
getNextToken();
return Params;